Welcome Guest [Log In] [Register]
Welcome to Chaos Realm!!!


You're currently viewing our forum as a guest. This means you are limited to certain areas of the board and there are some features you can't use. If you join our community, you'll be able to access member-only sections, and use many member-only features such as customizing your profile, sending personal messages, and voting in polls. Registration is simple, fast, and completely free.


Join our community!


If you're already a member please log in to your account to access all of our features:

Username:   Password:
Multiquote Multiquote
Add Reply
[GUI] Saber Spellpack; Fate Staynight/ zero
Topic Started: Feb 5 2016, 05:24 AM (4,186 Views)
Syaoran clone
Member Avatar
BeastMaster Level 7
[ *  *  *  *  *  *  * ]
this spellpack follow game.
Credit
-Saber spellpack by Syaoran Clone
-Sound: Ripped by me.
-Music: Final Spark ( Anime: Fate Zero)
-Thanks to:
+Blitz : Saber Models, Sfxs
+Redstomer: Support Video 3ds and ideas
+Someone who makes sfx i used
+NEBS Seziox and Soulife: First Saber spellpack and your Share
Add a new spell
Attached to this post:
Attachments: Avalon.jpg (221.89 KB)
Attachments: Counter.jpg (225.7 KB)
Attachments: Strike_Air.jpg (240.04 KB)
Attachments: Excalibur4.jpg (231.3 KB)
Attachments: Excalibur3.jpg (204.67 KB)
Attachments: Excalibur2.jpg (165.08 KB)
Attachments: Excalibur.jpg (219.36 KB)
Attachments: Saber_Spellpack.w3x (1.99 MB)
Attachments: 922904_1748410832056502_2577046275986327893_n.jpg (99.01 KB)
Edited by Syaoran clone, Apr 23 2016, 01:15 PM.
Offline Profile Quote Post
 
Wakawaffle
No Avatar
Militia
[ * ]
are you going to make a map? i really like your spells
Offline Profile Quote Post
 
Syaoran clone
Member Avatar
BeastMaster Level 7
[ *  *  *  *  *  *  * ]
Wakawaffle
Feb 14 2016, 02:27 AM
are you going to make a map? i really like your spells
I am going to make but my time doesn't allow me to be done my map. Thanks for your comment
Offline Profile Quote Post
 
RiskYourLife
Member Avatar
Crypt Lord Level 3
[ *  *  * ]
First of all, to make the reviewers job to review easier. Please include the spell code in your post.
your spells look cool by the way

Here's my review
-overall, the spell looks cool!
-your spell is GUI which mean it can't be cast more than one at a time
-the caster get paused when spell start and thats not good

whats to fix
-change the variables name, it just look too simple
-try to make your spell into MUI spell so it can be cast more than one at a time
-try to remove pause
-replace the cinematic with texttag

This is not the end of the review, there is still lot of things to fix in yourspell (I think)

EDIT : I've recheck your code and forgot to tell this :
-yourspell is hard to config for begginer
-also, its very hard to import
-you are using too many type of unit and thats makes importing progress very slow. Why don't you delete all of the
unit that using same data but different model and create a new type of unit and change its model to dummy.mdx.
Google if you don't know how to use dummy.mdx as spell dummy.

I would like your spell includes :
-configuration of Unit Type of the dummy, spell damage, spell AoE, etc...
-a simple guide on how to import your spell


Edited by RiskYourLife, Mar 18 2016, 05:02 PM.
Anime Warfare Project

Posted Image

Terrain : |||||||||||||||||||||||||||||||||||||||| - 87%
Trigger : |||||||||||||||||||||||||||||||||||||||| - 48%
Character : |||||||||||||||||||||||||||||||||||||||||| - 18%
Decoration : |||||||||||||||||||||||||||||||||||||||| - 60%
Offline Profile Quote Post
 
Unryze
Member Avatar


A good review, but let me review your review.

First of all, there is absolutely no need for MUI spells, as long as the spell isn't intended to be used by same characters/at the same time with same ID. It's always better to make a separate spell, not just use a copy of the trigger and edit visuals based on who uses it (aka unit ID or even player, whatever). It's a stupid rule on Hive that only allows MUI spells to be uploaded, and I can't stand it.

As for the pause, I agree, if you want to have a cast, there is in-game data on spells for that called cast, use that instead ;)

Cinematics are always a bad thing, the more spell eats time, the less players actually play, maps like FOA are the epidemy of bad programming.

So I agree with RiskYourLife on 99%, but with the MUI part ;)
My Map Topic:http://chaosrealm.info/topic/10567032/
Official Map Site::http://vendew.info
Skype: Unryze
Garena: Unryze
Anime Character Fight and BvO Another Map Maker
Offline Profile Quote Post
 
RiskYourLife
Member Avatar
Crypt Lord Level 3
[ *  *  * ]
Ah, i forgot that MUI spell is optional in Chaos Realm. I just got used with the MUI law in Hive and same as me, I can't endure the way of MUI spell making.
Anime Warfare Project

Posted Image

Terrain : |||||||||||||||||||||||||||||||||||||||| - 87%
Trigger : |||||||||||||||||||||||||||||||||||||||| - 48%
Character : |||||||||||||||||||||||||||||||||||||||||| - 18%
Decoration : |||||||||||||||||||||||||||||||||||||||| - 60%
Offline Profile Quote Post
 
Syaoran clone
Member Avatar
BeastMaster Level 7
[ *  *  *  *  *  *  * ]
RiskYourLife
Mar 18 2016, 12:39 PM
First of all, to make the reviewers job to review easier. Please include the spell code in your post.
your spells look cool by the way

Here's my review
-overall, the spell looks cool!
-your spell is GUI which mean it can't be cast more than one at a time
-the caster get paused when spell start and thats not good

whats to fix
-change the variables name, it just look too simple
-try to make your spell into MUI spell so it can be cast more than one at a time
-try to remove pause
-replace the cinematic with texttag

This is not the end of the review, there is still lot of things to fix in yourspell (I think)

EDIT : I've recheck your code and forgot to tell this :
-yourspell is hard to config for begginer
-also, its very hard to import
-you are using too many type of unit and thats makes importing progress very slow. Why don't you delete all of the
unit that using same data but different model and create a new type of unit and change its model to dummy.mdx.
Google if you don't know how to use dummy.mdx as spell dummy.

I would like your spell includes :
-configuration of Unit Type of the dummy, spell damage, spell AoE, etc...
-a simple guide on how to import your spell


Thanks for your review. I agree the things you said but about Caster get paused, i dont have ideas to remove pause, pause caster is a simple way to keep caster until the spell ends however if a spell is with non pause! The caster must stop cast spell when it attacks or moves ! It needs hashtable to do that but i am not good at them. The next, cinematics just use for Final skill like anime or game.
Offline Profile Quote Post
 
Syaoran clone
Member Avatar
BeastMaster Level 7
[ *  *  *  *  *  *  * ]
Update a newwspell
Offline Profile Quote Post
 
RiskYourLife
Member Avatar
Crypt Lord Level 3
[ *  *  * ]
I forgot to tell about the code leak. Anyway, here my new review

Spell Review (4/21/2016)

Visual:
-Awesome effect placing! :thumbs-up:
-The Strike air : Hammer of wind king caster get unpaused late. It should get unpaused right after the target knocked.
-About the cinematic, I think I can accept it but please reduce the cinematic duration. Maybe make it as channeling spell.

Code:
-I found a lot, a LOT of leak, SAME mistake. (found it in unit group. Can cause serious leak if cast on huge number of enemy)

Flexibility:
-You're using ton of dummy unit type which can be replace with dummy.mdx.
-The code is easy to config. :thumbs-up:

Rating:
Visual : 4.90
Code : 3.00
Flexibility : 4.00

Overal Score: 3.96
Reviewed by RiskYourLife


You see the score I give. You just need 0.04 point to get yourspell into Highly Recommended Spell category so please, please fix the code.
Moving to Recommended Spells
Edited by RiskYourLife, Apr 21 2016, 03:20 PM.
Anime Warfare Project

Posted Image

Terrain : |||||||||||||||||||||||||||||||||||||||| - 87%
Trigger : |||||||||||||||||||||||||||||||||||||||| - 48%
Character : |||||||||||||||||||||||||||||||||||||||||| - 18%
Decoration : |||||||||||||||||||||||||||||||||||||||| - 60%
Offline Profile Quote Post
 
Syaoran clone
Member Avatar
BeastMaster Level 7
[ *  *  *  *  *  *  * ]
RiskYourLife
Apr 21 2016, 03:17 PM
I forgot to tell about the code leak. Anyway, here my new review

Spell Review (4/21/2016)

Visual:
-Awesome effect placing! :thumbs-up:
-The Strike air : Hammer of wind king caster get unpaused late. It should get unpaused right after the target knocked.
-About the cinematic, I think I can accept it but please reduce the cinematic duration. Maybe make it as channeling spell.

Code:
-I found a lot, a LOT of leak, SAME mistake. (found it in unit group. Can cause serious leak if cast on huge number of enemy)

Flexibility:
-You're using ton of dummy unit type which can be replace with dummy.mdx.
-The code is easy to config. :thumbs-up:

Rating:
Visual : 4.90
Code : 3.00
Flexibility : 4.00

Overal Score: 3.96
Reviewed by RiskYourLife


You see the score I give. You just need 0.04 point to get yourspell into Highly Recommended Spell category so please, please fix the code.
Moving to Recommended Spells
Ow Hm thanks... maybe sunday or Saturday for the next update ver
Offline Profile Quote Post
 
Syaoran clone
Member Avatar
BeastMaster Level 7
[ *  *  *  *  *  *  * ]
Update ver1
Offline Profile Quote Post
 
RiskYourLife
Member Avatar
Crypt Lord Level 3
[ *  *  * ]
Nice, I gonna do a full recheck of your code. Hopefully, your code level will equal to those Highly Recommended Spells code.

Ahh, one more thing (very important)
Please change the test map name to something like "myspell_v2.0.w3x" so user can recognise which version they're using.
Also, please add Changelog.


EDIT:

Hmmm...
Sadly I still found leaks in your code. Since you can't find it, I will tell where it is

1. Air Cut (trigger name)
-destroy/remove the Saber_Point[21] location

2. Excalibur Sword of Promised Victory
-destroy/remove the Saber_Point[7] and Saber_Point[8] location

3. Excalibur Sword of Promised Victory Loop
-destroy/remove the Saber_Point[7] and Saber_Point[8] location outside the
(Distance between Saber_Point[7] and Saber_Point[8]) Greater than 150.00
if statement

4. Strike Air Hammer of the Wind King
-destroy/remove the Saber_Point[11] and Saber_Point[12] location

5. Strike Air Loop
-destroy/remove the Saber_Point[11] and Saber_Point[12] location outside the
(Distance between Saber_Point[11] and Saber_Point[12]) Greater than 150.00
if statement

6. Avalon The Everdistant Utopia (bug)
-the spell will only trigger when the spell level is 1 so what will happen if the spell
is level 2 or higher. Change (Level of Avalon : The Everdistant Utopia for (Attacked unit)) Equal to 1
to (Level of Avalon : The Everdistant Utopia for (Attacked unit)) Greater than or equal to 1
I know this is unnessary, but imagine what will happen when some careless user change
the spell level to higher than 1.

-destroy/remove the Saber_Point[15] and Saber_Point[16] location

7. Avalon The Everdistant Utopia Loop
-destroy/remove the Saber_Point[17] location inside the
(Distance between Saber_Point[15] and Saber_Point[16]) Greater than 150.00
if statement

8. destroy/remove the Saber_Point[3] and Saber_Point[4] location outside the
(Terrain pathing at Saber_Point[4] of type Flyability is off) Equal to False
if statement

Edited by RiskYourLife, Apr 23 2016, 02:07 PM.
Anime Warfare Project

Posted Image

Terrain : |||||||||||||||||||||||||||||||||||||||| - 87%
Trigger : |||||||||||||||||||||||||||||||||||||||| - 48%
Character : |||||||||||||||||||||||||||||||||||||||||| - 18%
Decoration : |||||||||||||||||||||||||||||||||||||||| - 60%
Offline Profile Quote Post
 
abcd
No Avatar
Peon
[ * ]
Are there any update without leaks in this spell pack.
Offline Profile Quote Post
 
Syaoran clone
Member Avatar
BeastMaster Level 7
[ *  *  *  *  *  *  * ]
abcd
Dec 1 2016, 07:06 AM
Are there any update without leaks in this spell pack.
Sorry I am busy with projects and the exam. I will update later
Offline Profile Quote Post
 
1 user reading this topic (1 Guest and 0 Anonymous)
« Previous Topic · Spellpacks · Next Topic »
Add Reply

War3 Modding

Blizzard Modding

Other Games

Community

MARKET
Models & Skins
Spells
Ongoing Contests
Hosted Projects
World of Warcraft
Starcraft 2
Diablo III
Heroes of the Storm
Dota 2
League of Legends
Members
Awards
Introductions
Contact

Copyright © 2011-2015 Chaos Realm. A project initiated by Bogdan Radu.